Bug #653

cMessage::getEventDuration() semantically wrong

Added by Mirko Stoffers about 7 years ago.

Status:NewStart date:03/04/2013
Priority:LowDue date:
Assignee:-% Done:


Target version:-


The function cMessage::getEventDuration() is semantically wrong. While this does not impose a direct bug since all functionality is $somewhere, it makes the code hard to read and understand.

The getEventDuration() function should only determine and return the duration of an event. However, it additionally checks whether the module the event takes place on is currently busy or not, and spins if necessary. This functionality should go somewhere else.

Further, we should re-think the caching policy. It appears to be correct, but looks missleading.

Also available in: Atom PDF